- Language: PHP
- Stars: 0
- Repository: https://github.com/Dankirk/strictlybetter
#8Scryfall bulk-data files contain card spoilers with temporary "joke" names during the period their real names aren't yet known. These cards also end in Strictly Better database and should be renamed/removed once the real card name is known (available in scryfall-default-cards.json). Currently both versions of the card exist in the database simultaneously. If the spoiler cards are removed, any existing obsoletion and vote data on them should be transferred to the published card.
#6There seems to be a bug in card rules text substitution, which is supposed to replace any instances of cards own name within the cards rules text with '@@@'. The bug happens with cards that have names that start with a special character, such as " (double quote). The bug causes the rules text remain in it's original form and thus the card cannot be considered functionally equal when trying to find strictly better cards programmatically during 'create-obsolete' artisan command or when finding functional reprints during 'populate-functional-reprints' artisan command. Once solution is found, a new artisan command should be created to replace each Card models substituted_rules attribute to match the new substituted rules in case they differ.
#4Currently there are cards in Scryfall bulk-data files such as Experience that work as a place to put counters on. These type of non-playable cards shouldn't be added to database during full-update / load-scryfall artisan commands. To remove existing cards in database artisan command 'remove-bad-cards' should be updated to work with the same rule set as the filtering during load-scryfall command. This way the same filtering happens between both commands and only one section in the code needs to be updated if similar case happens in the future. After removing existing cards in the database, functional_reprints table should be checked if there are any orphaned entries left and remove any that are.
#1Currently game formats are hardcoded in Card model. To automatically keep the formats updated, formats should be parsed during card db upgrade, which happens with artisan console command: load-scryfall. Keep sure the formats listed on Browse page are still listed pretty (first letter capitalized, underscores turned to spaces) Scryfall API documentation should be checked if there are any other ways to see the formats than the card data in bulkdata files.